-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config docs and README refresh #2393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great!
I left a few comments.
Co-authored-by: Heather Cloward <heathercloward@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These updates look great!
…ing method and improve docs/examples on that page
Co-authored-by: Heather Cloward <heathercloward@gmail.com>
@AlexVarchuk could you please check over these changes? I've completely rewritten the HTML deployment page, removed the old quickstart and directed people to the HTML page as our easiest onboarding. If you are happy that everything looks accurate, then I think we are probably good to go. Thank you! |
@lornajane It looks good to me! Thank you! 🙌 |
|
||
- [npm](https://docs.npmjs.com/about-npm) | ||
- [yarn](https://classic.yarnpkg.com/en/docs/getting-started) | ||
:::Success URL or local file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a lowercase s
in success.
|
||
### More usage options | ||
|
||
Check out the [deployment documentation](./deploment/index/md) for more options, and detailed documentation for each. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link looks wrong.
Thanks! and Yep! Without preview tooling, we missed things when I was writing and in review. I fixed at least one of these on the related sidebars PR on the marketing website. |
* docs: Give Redoc a landing page with overview and tldr instructions * docs: move config to dedicated page * docs: modernise README, link to resources * docs: more detailed format for theme configurations * fix: README formatting * fix: Fix future tense errors and add exceptions for config fields as headings * Apply suggestions from code review Co-authored-by: Heather Cloward <heathercloward@gmail.com> * docs: minor updates from excellent pull request feedback * docs: Remove the old quickstart, update HTML as the preferred onboarding method and improve docs/examples on that page * Apply suggestions from code review Co-authored-by: Heather Cloward <heathercloward@gmail.com> --------- Co-authored-by: Heather Cloward <heathercloward@gmail.com>
What/Why/How?
Configuring Redoc can be confusing, partly because we use our central configuration docs, with some-but-not-all options supported in Redoc. Also the README on this project is epic. This pull request slims down the README, creates a dedicated page for configuration options, and also a docs landing page in case anyone finds the project that way on our main docs.
Check yourself